Ignacio Lozano

Results 5 comments of Ignacio Lozano

I tested the SNAPSHOT locally in my project and it works, however, the test in this draft doesn't run. Please, could you give some feedback before trying to fix the...

Hi @nmck257 , thanks for your suggestion. I've reviewed the spring boot code for both versions, and I think we should replace `maven.compiler.source` and `maven.compiler.target` usages with `maven.compiler.release`. Spring boot...

@nmck257 I think this should cover all the cases using the built-in recipes ```yml # Since JDK 17 `release` is used and defined in Spring Boot parent project - org.openrewrite.maven.RenamePropertyKey:...

About `java.version`, that's right, it is a more general way to define source&target in Spring. If we keep this change on spring-rewrite, we could use `java.version` instead of `maven.compiler.release`. Otherwise,...

Sorry @nmck257 , just one more thing before closing this PR. I think this [rewrite gradle recipe](https://docs.openrewrite.org/recipes/gradle/updatejavacompatibility) is similar to what we discussed. I am tempted to port the recipe...