Daniel Wagner-Hall
Daniel Wagner-Hall
I finally got around to taking a look at this, and have put together [a draft branch](https://github.com/illicitonion/cargo/commits/digest-files). It's a relatively simple change, and not particularly invasive. The top three commits...
Gosh, I'm not sure how I missed that #8623 came into existence - I'll do some catching up on it soon and get back to you, very happy to work...
I got a non-trivial crate (https://github.com/pantsbuild/pants/tree/c8b42cb52eca9acbca98eaaf9599a47bc7b1f51e/src/rust/engine) compiling with `-Z minimal-versions`, and have started sending out a few PRs to the ecosystem. My two big questions from this process are: 1....
/cc @achew22 @sluongng @linzhp
Yeah, that's exactly right @linzhp.
Thanks for the thoughts! > `BaseLang` should contain a sensible default implementation for `LoadsWithConfig(...)` and `KindsWithConfig(...)` This generally sounds reasonable, except that I'm not sure what that sensible default implementation...
Sorry, I simplified our use case to the example of flaky tests (which I agree doesn't necessarily pull its weight as motivation) - a better example for us than flaky...
> `//gazelle-extensions/java_flaky` and `//gazelle-extensions/java_network` will generate specific kinds of Java targets when they see `@Flaky` or `@ RequiresNetwork`. Then //gazelle-extensions/java can skip the Java files that have been consumed by...
Absolutely: ```starlark load("//some:custom.bzl", "requires_network") java_test( name = "OrdinaryTest", srcs = ["OrdinaryTest.java"], deps = [ ":helper", "//junit", ], ) requires_network( java_test, name = "RequiresNetworkTest", srcs = ["RequiresNetworkTest.java"], deps = [ ":helper",...
> Do you want `OrdinaryTest` to have deps for `RequiresNetworkTest`, even though `OrdinaryTest.java` doesn't import them? Ideally they would have independently gathered deps. But the logic for gathering the deps,...