Joe Spandrusyszyn

Results 9 comments of Joe Spandrusyszyn

This same issue causes problems in other situations, which the PR would solve. For example... 1. Show a component that adds a CSS class to the body element that changes...

Nope - the behavior is the same for both sync and async. I think the issue is because you're creating a snapshot of the router: https://github.com/scottrippey/next-router-mock/blob/d786607dbdc04819d37f4d9eaa32bec41c2a544e/src/useMemoryRouter.tsx#L15C1-L15C86

I forked your CodeSandbox and added a `routeChangeComplete values` section that demonstrates the behavior we're relying on: https://codesandbox.io/p/sandbox/holy-platform-kk7qfj

@capricorn86 I've created a repo to reproduce a leak: https://github.com/illandril/happy-dom-leak My reproduction uses `@testing-library/react`, so it might only be some interaction between happy-dom and testing-library that leads to the leak...

After some additional testing, the issue seems to also happen when clicking on a label linked to an input via `for="..."`, not just when the label wraps the input.

Also, this is not limited to just checkbox inputs, it just is most disruptive for checkbox inputs (since it will check and then immediately uncheck the checkbox).

Generally speaking, this version should perform faster than stock box2dweb (at least the specific version this is based off of). It is possible that the difference in performance between your...

I would not accept a push with renaming, because I want people to need to make as few changes as possible to switch over from a different Box2D implementation. Also,...

I just did some work to reduce the number of warnings in my fork (I took care of about half of them so far), and added a mention of your...