Ilja van Sprundel

install breaks

3

I tried to follow the quick start install instructions. didn't work :(: ilja@meatdripper:~/dream/example/2-middleware$ npm install esy && npx esy > [email protected] postinstall /home/ilja/dream/example/2-middleware/node_modules/esy > node -e "process.env['OCAML_VERSION'] = process.platform ==...

consider using size_t instead of int for length

1

Currently str uses (signed) int for all lengths/sizes/capacity. when handling large strings (~2g and up, which is fairly realistic these days on 64 bit machines) signedness issues occur and memory...

set client rcMask to NULL after freeing

1

libvncclient does not currently free rcMask, but if it ever does, the current code would trigger a double free. Set client->rcMask to NULL after freeing to prevent this scenario.

https://github.com/microsoft/ProcMon-for-Linux/blob/ad86920331dda3315538ab0ee30fb24727aff82d/src/procmon.cpp#L17 line 17 checks the effective uid, signalling it's ok to come from a set user id root environment. However, right under it there's a call to system(), which clearly...

readme.md references README.win32.txt, but there is no such file

1

would be nice if the instructions on how to install this on windows would be available. There is a reference to it, but the file isn't actually there.