ilanjb comments

Results 9 comments of


                                            ilanjb

Need a way to retry commit on batch_writes

it seems like max_retry_attempts in meta will handle this. Thanks, class Meta: max_retry_attempts = 5

Need a way to retry commit on batch_writes

Reopened. The retries are after the failure. They do not help in this case.

set _first_iteration once, after first successful operation

While handling some manual retries I encountered this issue. I was getting the below error since self._index was not set even though self._first_iteration was already False ``` File "/pynamodb/pagination.py", line...

set _first_iteration once, after first successful operation

@garrettheel thanks for the feedback! ResultIterator._first_iteration would be set to False after the successful completion of the first query, right after `page = self._operation(*self._args, settings=self._settings, **self._kwargs` That guarantees that when...

Can't use the discriminator as a primary key in indexes.

@ikonst @abcydybcy I just ran into this issue, as well. If Pynamodb really wants to prevent this behavior, I suggest throwing an exception on Model._get_schema() when encountering the behavior. If...

Can't use the discriminator as a primary key in indexes.

@ikonst yes I'm talking abouy querrying a GSI that has a "discriminator_attr" as the hash or sort key. false / true are relative. Just a way to control whether on...

Can't use the discriminator as a primary key in indexes.

@ikonst want me to create an MR?

set _first_iteration once, after first successful operation

@Yaronn44 not sure about changing the codebase, but I've been using the class I pasted in https://github.com/pynamodb/PynamoDB/pull/1059#issuecomment-1207445066 for a few months without problems.

Can't use the discriminator as a primary key in indexes.

@ikonst I noticed I neglected to thank you for your thoughtful reply. Thanks! If you get a chance, just raising an error would definitely be a good enough solution.