ikopylov comments

Results 54 comments of


                                            ikopylov

218 filters inner locks

There should also be a PR on Bob side that uses this improvement

207 preserve delete

There is a warning about `created` function. Previously, I suggested to keep that function, but if its presence generates warning then it is better to remove it (like you did...

Rename `Blob::read_any` to `Blob::read_last`

Additionally, we should rename `get_entry` to `get_last_entry`

Improve File::blocking_call perf

We should check `block_in_place` function: https://docs.rs/tokio/0.2.22/tokio/task/fn.block_in_place.html Probably, there should be a compromise strategy (should be verified by performance tests): if data size is less than 4Kb, then call blocking function...

Avoid copying data during serialization of `Record`

Related to https://github.com/qoollo/pearl/issues/189

Investigate the possibility of receiveing data as a slice

We can use `Bytes` (https://docs.rs/bytes/latest/bytes/struct.Bytes.html) instead of slice, if it is impossible to use slice to achieve zero copying

Include key size into BLOB header

Questionable as it may complicate support for configurable key types

572 join error

I searched for information about the `cancelled` error. There are comments in several places where it is indicated that there is a possibility that there will be a cancellation error...

Investigate possibility of using jemalloc or memalloc for musl target

Works with https://crates.io/crates/tikv-jemallocator But should be used only for musl target. Also custom feature `jemalloc` should be declared