Ikhun Um comments

Results 365 comments of


                                            Ikhun Um

Provide a decorator/utility that can send a gRPC response.

> NPE is just ignored, because Throwable is caught and closeCalled is true in this case. Let me take a look.

Test failure: `LocalArmeriaPortHttpsTest.testPortConfiguration`

Fixed by #4395

Support `@Blocking` annotation for gRPC services

It's all yours. ❤️

Support custom method of gRPC HTTP endpoint

Hi, the PR has been worked by @hyangtack, an external contributor. As far as I know, he spent his spare time making the feature. So it is difficult for me...

Change the insertion order of `ExceptionHandlerFunction`

Another considering point could be the consistency of behavior of error handlers. - Thrift: start routing decorators Thrift error handler service (rpc)decorators service - gRPC: start routing decorators service decorators...

Test failure: `com.linecorp.armeria.spring.actuate.ArmeriaSpringActuatorAutoConfigurationSecureTest.normal()`

/cc @kojilin

Test failure: `com.linecorp.armeria.spring.actuate.ArmeriaSpringActuatorAutoConfigurationSecureTest.normal()`

> `bind(..) failed: Address already in use` I missed the part. By the way, I'm failing to find the test suite where a random port is passed. Could you point...

Test failure: `com.linecorp.armeria.spring.actuate.ArmeriaSpringActuatorAutoConfigurationSecureTest.normal()`

I tried to retry the failure but it was difficult to apply because the failure occurred while an application context is initialized. So the tests were never invoked at all....

Provide a way to run service code out of I/O event loops

Thanks for your initial contribution. 🙇‍♂️ We are happy to take over the remaining work.

Provide a way to run service code out of I/O event loops

> I think all comments are addressed now Welcome back! ❤️