Iliia Khaprov - VMware by Broadcom
Iliia Khaprov - VMware by Broadcom
@dcorbacho @dumbbell I also looked at exchange - https://github.com/rabbitmq/rabbitmq-server/blob/master/deps/rabbit/src/rabbit_exchange.erl#L114 and I see the same pattern here: decorator call; ...; mnesia operation. Looks like another race condition possible here?
I think it is safe to merge this one. README script works, no errors on dashboards, they look clean and native grafana export produces exactly same json as in the...
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/messaging.md
thanks for pinging. RabbitMQ supports natively AMQP 0.9.1 and 1.0 as well as MQTT up to 5 and STOMP.
lol, forgot about this one
with this addition https://github.com/rabbitmq/amqp091-go/pull/96 publishing interface becomes really nice - we don't have to use carriers/propagator concept for publishing and just pass our context.
I don't think we need something special here. IIRC by default the propagator is no-op.
by configuring OT SDK to use "proper" propagator :-) For example: https://github.com/open-telemetry/opentelemetry-go/blob/e6839571d26cfc6458050da275f79618fbfd4d9d/propagation.go#L30. It's up to our users to set configure. We going to use only API part.
https://github.com/rabbitmq/amqp091-go/compare/main...ik-tracecontext-bump simplest way of doing context injection into message. On consume/get side the call to otel.GetTextMapPropagator().Extract(ctx, msg) will be needed. Key names, for headers, their format is up to propagator.