Taishi Ikai

Results 8 comments of Taishi Ikai

Hi @freak4pc, I would like to take over this PR and could you review #41?

@mr-bjerre Your integration would help much people including me. Could you proceed with a PR?

I have used your code in some projects and it would be more useful if it maintained in the contrib dir. If you say so, could I make a PR...

ok, I'll do it soon.

Hi @lzchen and @jeremydvoss, I'm waiting for your code reviews. Thank you

Thanks for your review. I have corrected the points you raised. @lzchen Maybe your CLA is missing and the build is failing. Could you sign it? or should I rebase...

Thank you @lzchen, CLA passed and I fixed that test passed!

Hi @lzchen, I fixed lint issues and confirmed tox passed locally.