Iiro Jäppinen comments

Results 336 comments of


                                            Iiro Jäppinen

.swcrc file not read

Thanks @Kaciras. Maybe the `README` could be updated for this.

docs(monorepo): improve docs

The comment is incomplete by mentioning only package.json. The point is that an empty config file in the root is not needed at all if there are already multiple config...

[Feature Request] Provide option to hide all unstaged files (partially or not)

Let's leave this open for now, for consideration. There has been some issues in the past related to this, and that's why we currently do not touch unstaged files at...

No docs on suggesting how to debug custom scripts. argv does not have staged files on debugging custom scripts.

Does it work if you add a double-dash: ``` node ./lint-staged-scripts/customScript -- ```

lint command task causing errors

Please post your debug logs by running _lint-staged_ with the `--debug` flag.

`lint-staged` fails to run on Github Actions workflow: ✖ Failed to get staged files!

I would suggest trying to fetch all remotes or something before running. The error message isn't very helpful in this case.

Checker output not printed on error in DUMB terminal

Thanks for the report. We do those separately from the `listr2` output here: https://github.com/okonet/lint-staged/blob/383a96e17a21d10278e91ecdb8d80385886ce82f/lib/index.js#L122 Not sure what causes it... maybe it's something to do with `listr2` renderer config?

Creating chunks when it is not needed

The current chunking logic is based on the length of string from joining all filenames. In this case I guess it should instead be based on the string generated from...

Creating chunks when it is not needed

Looking at the code in `lib/runAll.js`, it might be more involved... Currently we first chunk, and then generate tasks per chunk. In this case we should do it the other...