Michael Gargano

Results 28 comments of Michael Gargano

I'm not even sure what the original issue was here. But I'm pretty sure everything is okay? The thing we are missing is the maxo diagnostic merge on release?

After investigating, I need to update for the diagnostic merge script. I'll get on it

Hi @dnmaslennikov0ngsdataint and @pnrobinson After investigation we have found the source of problems are a result of a bug at medgen. We ingest this file [ftp://ftp.ncbi.nih.gov/gene/DATA/mim2gene_medgen](https://ftp.ncbi.nih.gov/gene/DATA/mim2gene_medgen) As a temporary solution...

This has been released. We have been notified that medgen has fixed the bug in the pipeline.

https://github.com/monarch-initiative/phenol/blob/96d3ea4f93610d483318e96d3c8e28cbb331cdf0/phenol-annotations/src/main/java/org/monarchinitiative/phenol/annotations/formats/hpo/category/HpoCategoryMap.java#L29 These are defined here. Are we thinking as a category Abnormal musculoskeletal physiology HP:0011843 - Musculoskeletal System @peupeubangbang @pnrobinson

- we do not need the scheduled run - the job should fail if there are broken links and we should report them

Thanks for the feedback! I've addressed both issues: ✅ **Removed scheduled run** - No more weekly cron job ✅ **Job now fails on broken links** - Removed `--keep-going` flag so...

✅ **Configured linkcheck to allow redirects** Updated the sphinx configuration to treat redirects as successful while still catching genuine broken links: ## Configuration Changes - **Allow all redirects** - Redirects...