ihsinme
ihsinme
sorry i don't understand what JtR is. I just noticed that you have a wrapper function with `fseek` error checking, but there are also simple `fseek` calls. I think it...
indeed, you have a lot of places with checks. but I paid attention to these 13 places. https://github.com/openwall/john/blob/8585c3f605521478c629d4a87ba4b67c34038a3e/src/base64_convert.c#L1086 https://github.com/openwall/john/blob/8585c3f605521478c629d4a87ba4b67c34038a3e/src/base64_convert.c#L1088 https://github.com/openwall/john/blob/6dca7c39c56fbf7463de2ef6690ec557b2b51d6e/src/keepass2john.c#L260 https://github.com/openwall/john/blob/6dca7c39c56fbf7463de2ef6690ec557b2b51d6e/src/keepass2john.c#L340 https://github.com/openwall/john/blob/6dca7c39c56fbf7463de2ef6690ec557b2b51d6e/src/keepass2john.c#L342 https://github.com/openwall/john/blob/6dca7c39c56fbf7463de2ef6690ec557b2b51d6e/src/loader.c#L1914 https://github.com/openwall/john/blob/6dca7c39c56fbf7463de2ef6690ec557b2b51d6e/src/loader.c#L1917 https://github.com/openwall/john/blob/6dca7c39c56fbf7463de2ef6690ec557b2b51d6e/src/opencl_common.c#L2174 https://github.com/openwall/john/blob/6dca7c39c56fbf7463de2ef6690ec557b2b51d6e/src/opencl_common.c#L2176 https://github.com/openwall/john/blob/6dca7c39c56fbf7463de2ef6690ec557b2b51d6e/src/pp.c#L1519 https://github.com/openwall/john/blob/6dca7c39c56fbf7463de2ef6690ec557b2b51d6e/src/pp.c#L1522 https://github.com/openwall/john/blob/6dca7c39c56fbf7463de2ef6690ec557b2b51d6e/src/wpapcap2john.c#L228 https://github.com/openwall/john/blob/6dca7c39c56fbf7463de2ef6690ec557b2b51d6e/src/wpapcap2john.c#L230
@solardiz. Thank you for your attention. I'm really looking for bugs that developers don't like to fix. and really I do it within the framework of static code analysis. maybe...
> Thanks for the contribution. How does this query relate to `cpp/overrunning-write` and the `BufferWrite` library? if you mean how it differs then it is: 1. functions set 2. simplicity...
I think you know better. but my query is just expanding, it actually needs a mechanism to look up the functions contained in the main call `sizeof(var)` and `var`, and...
> Besides the qhelp problem this looks ok. As I mentioned in the other PR I'm reviewing, more descriptive variables names would help, `b`, `s`, `bpos` and `spos` are not...
> > > Were you planning to submit this for a security bounty? > > > yes I plan > > You'll need to submit this before we merge this....
@jketema thanks, I watched it. I think your fix is closer to [Parameterized annotations](https://codeql.github.com/docs/ql-language-reference/ql-language-specification/)
good afternoon @jketema. any news on this PR?