Results 27 comments of Igor Ostapenko

I would like to notice that this is what stops me from migrating to JanusGraph.

Good notice, thank you. I agree that pstash will be better if it follows existing stash. Going to revise it.

I've prepared the simplest conditional build to fix Kyua build for non-FreeBSD: https://github.com/ihoro/kyua/commit/8b50c22f196a93ad1a69b1709cb77b5fdc31534e. Let me know if we would like to have a separate `freebsd/` src dir for FreeBSD specifics....

There is the second candidate for the next PR: https://github.com/ihoro/kyua/commit/4dffd2650f9bc59d77af32275d8ab73573443322. It's a bigger patch, but it collects FreeBSD specifics into a separate `freebsd/` src dir.

And there is another commit in the queue to become a PR: https://github.com/ihoro/kyua/commit/0d319defa0bf19460a1baa1be06edd0275833f12. It gets Kyua tests back to the pre-patch state: `Test cases: 1472 total, 22 skipped, 0 expected...

The following topics are closed by current state of the patch: - FreeBSD specifics are separated with conditional build. - The existing tests, broken by the change, are fixed. -...

@ngie-eign, thank you very much for your time. Going to work on the outcome of the review.

> As much as I'm not a fan of the term "container" because it focuses on the Linux/Solaris technological implementations, I believe that it would be wise to use "container"...

Anyway, now I think that `execenv.jail` could be re-worked into `execenv.jail.params` to keep the "namespace" for possible future improvements of jail execenv with extra `execenv.jail.*` metadata.

@ngie-eign, I'm leaving the "Resolve conversation" button for you. I guess it must be convenient for you.