Igor Terzic

Asserts thrown in `didSaveRecord` don't put the record in the correct rejected state

1

If you hit https://github.com/emberjs/data/blob/1428e26cb49181bf38cc62b98eaa40d255ef7d11/packages/store/addon/-private/system/core-store.ts#L2603, the record will end up in a half broken state, rather than putting it in a correct error state, the way it would if the request...

Confusing error message inside record-data.ts

1

Passing improper payloads sometimes results in error messages that look like: ``` Assertion Failed: Encountered a relationship identifier without a type for the hasMany relationship 'zones' on , expected a...

https://github.com/hjdivad/ember-m3/pull/611/files#r394758268

Non US phone numbers do not validate correctly

4

Added a test at https://github.com/offirgolan/ember-validators/pull/46 Maybe for something as complex as phone number, we should delegate to an external/more robust library?

Output is full of ^[[32m and ^[[39m

1

If I pipe the output into a file when it can't fit into stdout there are a lot of weird characters around.

Migrator stripped window.mixpanel inside mixpanel.js and replaced it just with mixpanel

3

Not really sure how/why but this can lead to very hard to track down errors