Ian Kivlichan
Ian Kivlichan
+1, it was pointed out to me (didn't know this was a thing at all) that storing data in lib/.../site-packages is considered bad form and that that directory is usually...
Setters are usually not necessary without a specific reason, I think it's simpler to just change the variable here. Thoughts on saving into `cwd/OpenFermion-data/` or something instead of directly into...
@babbush I'd be surprised if it isn't more efficient to do the phase estimation controls by hand, rather than controlling the entire Trotter step. The reason for this is that...
@Strilanc @kevinsung is slicing in Cirq powerful enough that we could add CNOTs to a circuit in given positions, without changing anything else?
I don't think it makes sense to decide on or implement the outer loop for iterative phase estimation at this stage, especially without classical feedback. IMO the most important thing...
@Strilanc you can get a radix-3 FFT from the regular radix-2 definition - instead of splitting in two parts (with x(2n) and x(2n+1) getting the phase) you instead divide into...
See also https://coveralls.io/github/ProjectQ-Framework/FermiLib?branch=develop - our badge will update to 99%.
Yep, I'm on it now.
Fixing the imports was not enough, there's a deeper problem somewhere in the call to energy_objective. I'll continue to look at this.
OK, I have a fix. The problem was pretty subtle and is not related to my changes, though in retrospect I should've thought of it earlier. I'll send a PR...