Ian Connor
Ian Connor
This was included from a react template we got from https://www.creative-tim.com/ - I will let them know about your updated project.
It looks like with the new include the older versions of node break: Node ≥ 10 pass but Node ≤ 8 fail
Once I limit it to current releases (12 onwards): https://en.wikipedia.org/wiki/Node.js#Releases The build should pass on Travis: https://travis-ci.com/github/iconnor/node-modbus/builds/234171373
@stefanpoeter, what are your thoughts on limiting the tests to supported Node versions only?
If people are running versions lower than the supported ones, they are open to vulnerabilities. It is safer to mark the 2.0.1 release as the last supported version for those...
@stefanpoeter what do you think of limiting to only supported releases and updating the readme?
Is this okay to merge?
I just went for the closest patch just in case the jump to 5 introduced regressions of some sort.
@stefanpoeter and @alexbuczynsky - I saw dependabot added three PRs and just pushed a new commit that updates `npm audit` that also would resolve those issues.
Has anyone tried this with 7020G?