Ian Schmitz

Results 48 comments of Ian Schmitz

Thanks for filing the issue @zaqqaz. I've copied the latest logic from `jest-environment-jsdom` which I believe has sorted the issue. I have published `1.0.0-alpha.0` which has removed the warning in...

I've done some more testing and it appears that i'm still seeing the warning. The warning disappears when using the same version of jsdom that Jest uses. However when i...

/cc @SimenB sorry to ping you. Wanted to bring to your attention as you guys might run into this when you eventually drop Node 6 support and bump jsdom. From...

It does indeed. https://github.com/theneva/jest-environment-jsdom-thirteen also gives the same memory leak warning. I have a package up for jsdom 15 which has identical source to this one - https://github.com/ianschmitz/jest-environment-jsdom-fifteen.

A setting in `tsconfig.json` our team found super helpful is: `"defaultSeverity": "warning"`. This will report lint errors as warnings during development (`npm start` or `npm run build`), but when `CI=true`...

You could also use the tslint equivalent and leave the compiler option disabled.

This is the closest one: https://palantir.github.io/tslint/rules/no-unused-variable/. However note that because it requires type info, if you're using the VSCode TSLint extension, it doesn't display linting errors that require type info....

@gnapse refer to my comment above at https://github.com/wmonk/create-react-app-typescript/issues/333#issuecomment-394448666

@nickmccurdy this is a fairly significant change for this project. All your points make sense and are totally valid, but i think we should carefully consider how we would plan...

Agree with @nickmccurdy. Would love to see https://github.com/facebook/create-react-app/pull/4837 make it in, then this fork could be deprecated.