Jan Lieskovsky
Jan Lieskovsky
> Maybe I haven't understood well your idea. > Do you want to "only" show scripts? Yes, just show the corresponding script that would be actually executed for that rule....
@apeschel > @iankko Thanks for the review! I've been pretty busy so it took a while to get to following up. I made all your suggested changes, with the exception...
> @iankko sqauashed @apeschel Brilliant, TYVM! One kind request yet though. The `s/KEYCLOAK_EXTENSION/KEYCLOAK_EXTENSIONS/g` issue got addressed within [KEYCLOAK-18143 JIRA](https://issues.redhat.com/browse/KEYCLOAK-18143) already (via https://github.com/keycloak/keycloak-containers/pull/321). That means, once you rebase this PR against...
> @iankko I already rebased on master when I squashed, there no merge conflict with master :) @apeschel Ok, great. Thanks!
@dale-fu @levicic PTAL once got a chance (I have tested the changes on single s390x / ppc64le hosts too, and they seems to WFM correctly there too AFAICT, but better...
> A few changes, @iankko. Thanks. @andymunro Fixed all of them, as suggested. Thanks!
Running the `om.redhat.xpaas.sso.ImageTest.testDeclaredEnvironmentVariables` XPaaS test on the current 7.5.X+ images returns the following output: ``` Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 31.472 s
@drichtarik @ASzc @pskopek PTAL once got a chance Thx, Jan
Yet, content of the promised `_argocd-operator.csv.clusterpermissions.yaml` (but it's truly just copy of upstream `rules:` defined in https://github.com/argoproj-labs/argocd-operator/blob/master/deploy/olm-catalog/argocd-operator/0.13.0/argocd-operator.v0.13.0.clusterserviceversion.yaml#L1680) ``` $ cat _argocd-operator.csv.clusterpermissions.yaml # Taken from (after removing the leading eight space...