Ian Hoffman

Results 5 comments of Ian Hoffman

Thanks for the quick response. This looks like it'll require a pretty fundamental change to the way the plugin generates prop types (at least if we want to support things...

Looks like what you're seeing is caused by this block in `starlette.routing.Route`: ```python3 if inspect.isfunction(endpoint) or inspect.ismethod(endpoint): # Endpoint is function or method. Treat it as `func(request) -> response`. self.app...

@tomchristie That seems reasonable. Are there worries about backward compatibility? IMO it's strange that routes can even accept an ASGI app as an argument. Doesn't an app have many routes,...

@florimondmanca this is a bigger change, but couldn't `HTTPEndpoint` (and other CBVs) be modified to accept a request object instead of a 3-tuple? The request holds information about scope, receive,...

Gotcha — using a CBV instead of a functional view does seem like a reasonable fix. That's probably good enough given this isn't likely to be a common issue.