Ian G. Maia
Ian G. Maia
> @iangmaia this test PR raises an interesting question. How to use SwiftLint with Danger _if_ Danger does not run on macOS. The problem in this case is using SwiftLint...
This is great -- I wonder if it wouldn't make sense to add it as a feature on Danger itself, though.
> Maybe it would be best to do the following: > > 1. Only use hardcoded version. I.e. remove the custom logic to read the version. > 2. Have a...
**Note**: this PR [was reverted](https://github.com/woocommerce/woocommerce-ios/commit/15615447965e725c148901fd46ca6d46944ac43b) for the `18.9` release.
@mokagio did it work? 🙂
I like the idea 👍 It moves the "burden" of part of the process from the devs to the RM (which was already kinda there anyway), plus potentially makes our...
It seems the problem is gone with the [Xcode 16.1 RC](https://developer.apple.com/documentation/xcode-release-notes/xcode-16_1-release-notes), so there's no need to work around it using a specific simulator version.
> our Windows CI supports running Bash For the scope of this issue, I agree we can consider this done 👍 > we could write integration-tests-like scripts for each command...
> as long as characters from `[a-zA-Z0-9/.-]` don't cause trouble (anymore?) that should be ok to use now? This seems to be the case as the images @mokagio generated so...
Thanks for this @mokagio! Looks like the build with the pipeline upload worked fine 🎉 I've merged #597 and released `12.2.0` for `release-toolkit`.