Iain Hannah

In XSPEC this works by being able to do simple arithmetic with the models and easily tie the fitting parameters, i.e. for detectors A and B your counts models are...

Testing has been done on single detector fits vs multiple simultaneously to check that consistent results are obtained and that the scaling parameter is within the expected range (usually about...

Got the generation working and created an example using the thermal model in sunxspex with default v7.1 and new v10.0.2 files, i.e. https://github.com/ianan/fvth_stuff/blob/main/python/test_thermal_sav.ipynb For resolution of instruments using (just sub-keV)...

@settwi Can do the PR but tried to use the new files for fitting and sunxspex crashes with `IndexError: index 84 is out of bounds for axis 0 with size...

Can confirm @KriSun95 fix works - but as discussed might be other issues with f_vth that need to think about (i.e. max energy range shouldn't be limited by continuum file?...

@KriSun95 Just to check but the temporary bug fix for this hasn't been implemented yet? As [L4756](https://github.com/sunpy/sunkit-spex/blob/cfd41b9e6eea5591f5e827bd89b34ac2f9dab0db/sunkit_spex/sunxspex_fitting/fitter.py#L4756C4-L4756C56) is still `_test_e_range = np.arange(1.6, 5.01, 0.04)[:, None]`

fyi, I have better versions of the chianti database files to use when fitting the thermal model (either in ospex or sunkit-spex) available here https://github.com/ianan/fvth_stuff/tree/main/better_chxdb The issue is that the...

There is an issue here, but f_vth should only be called by the fitting routines. When manually wanting to do emission models call them directly, i.e. `from sunxspex.thermal import thermal_emission`

Is the speed up here being tested just in calculating the model or also as part of the fitting? As some of these approaches (multi-threaded and maybe PyTorch?) might speed...

Fair enough - sadly no magic solution. Probably needs the C to do a fast and accurate integral.