ian hui comments

Results 6 comments of


                                            ian hui

[Improvement] Increasing the allowed range of Maxreplicas and setting both fields in replicasLimit to optional

@leon-inf The consideration of this design mainly comes from the following points: 1. Setting them as optional is mainly to take into account that users may only want to modify...

[Improvement] Increasing the allowed range of Maxreplicas and setting both fields in replicasLimit to optional

I still think 1. For example, in this case, we only want to modify the minReplicasLimit 0, and we don’t actually want to consider the maximum replicas value. 2. The...

[Improvement] Increasing the allowed range of Maxreplicas and setting both fields in replicasLimit to optional

> Setting maxReplicas to 2147483647 (math.MaxInt32) is not a reasonable choice, neither in the ReplicaLimits API nor as the default value in the KubeBlocks controller code. It is recommended to...

[Improvement] Increasing the allowed range of Maxreplicas and setting both fields in replicasLimit to optional

> > > Setting maxReplicas to 2147483647 (math.MaxInt32) is not a reasonable choice, neither in the ReplicaLimits API nor as the default value in the KubeBlocks controller code. It is...

feat: support validate policy of opsrequest

> fix the conflicts and make test error sorry that i forgot to push newest code. I have already push the newest version. plz check.

feat: support validate policy of opsrequest

> do not force push; retain commit history. all right. I'll make corrections