Noah Krause comments

Results 7 comments of


                                            Noah Krause

Dynamic CORS Origin matching using Envoy's `allow_origin_string_match`

@neomantra Exposing Envoy configuration is generally pretty straight forward so I imagine that someone in the community could raise a PR to add support for this. In the meantime, I...

Allow variable validation conditions to refer to other variables

Thanks for the great discussion on this thread. While this will not solve all of the use cases identified here, I thought I would share a workaround I discovered for...

patches should throw error on missing targets

While I agree there is definitely a reason to want Kustomize to fail if it does not make an intended patch, I believe this should be behavior that is configurable...

VRL doesn't honor `--color=never`

Is there any movement on this? I ran into it and would be happy to submit a PR for it if someone can help point me in the right direction

feat(canary): Support passing arbitrary set of labels to use for the query

@MasslessParticle Sorry for the ping but you seem to be the last person whose looked at the canary stuff https://github.com/grafana/loki/pull/14287 Is there anything I can do to get this over...

feat(canary): Support passing arbitrary set of labels to use for the query

@paul1r Sorry for the ping. Any chance we can get eyes on this or should I expect to need to fork the project to make this change?

feat(canary): Support passing arbitrary set of labels to use for the query

Thanks for the review @slim-bean and sorry for the delay in getting back to this! Appreciate the additions to callout the very simple parsing logic that is being done. Agreed...