Ian Norden
Ian Norden
> @i-norden I don't see much has changed since last time? Ah apologies, I embedded but with a named field instead of anonymously so it still had the methods reimplemented...
Also embedded `ds.Txn` into `txWrapper`, but since most the methods need to apply `ConvertKey()` the only ones this saved us from reimplementing are `Commit()` and `Discard()`
Thanks @hsanjuan! I appreciate the feedback. I'll take a look and test out that wrapper.
Hey @rvagg sorry for abandoning this, we are no longer using this work but if there is still general interest in these changes and/or the linked PRs it is dependent...
Unfortunately, fixing this clone issue only exposed further issues on Windows related to the MAX_PATH limit it enforces on path lengths. ``` fatal: cannot write keep file 'C:/Users/ianno/github/ibc-app-solidity-template/.git/modules/lib/vibc-core-smart-contracts/modules/lib/optimism/modules/packages/contracts-bedrock/lib/clones-with-immutable-args/modules/lib/ds-test/objects/pack/pack-7f56f56907d0ef629b2e0344644d535164a3c5c8.keep': Filename too...