Niels Abildgaard

You have been running npm publish with a polluted package.json, probably

1

In this repo `dot-json` is not a dependency. But on npmjs it is listed as such:  If you install user-agents with `npm install user-agents` you will see inside its...

Update changelog

4

The changelog has fallen behind as of recent. We should update it to make sure it reflects which changes were introduced in which versions.

2.0.0 (aka 1.0.0)

11

:star: **should not be merged** :star: This is a long-running branch that will exist while we are figuring out the exact interface of version 1.0.0 of this project. New changes...

Make it clear whether or not `message_id` and `registration_id` can be set in a result at the same time

1

I don't know whether they can, but we need to clarify this in the upcoming documentation (#98). Basically, when a `result` is returned from `Sender#send`, can it contain `result.results` entires...

Persistent connection and upstream messaging over CCS

6

CCS allows for a persistent connection between server and client. https://developers.google.com/cloud-messaging/ccs Upstream messaging (the server receiving messages from the clients) depends on CCS, and is the primary reason for implementing...

Support for creating notification keys server-side

8

It should be possible to create notification keys server side (used for sending user notifications). This, however, is not prioritised as highly as simply sending user notifications. See documentation: http://developer.android.com/google/gcm/notifications.html#gen-server

Better error reporting

3

Currently, if an invalid request is made, all that is returned is the error code. The debug message (when running with `DEBUG=node-gcm`) is not any more helpful. For example, I...

The tests should be looked into, and a plan for improvement laid. - Which areas are there that the tests should cover? - How many of these do the tests...

If an API key is invalid, no future requests will respond anything other than 401. That should be cached in the sender (because the sender depends on the API key),...

Make `addData(WithObject)` *add* data (not overwrite)

3

It seems misleading that the reference to the data object is overwritten with whatever is given to `addDataWithObject`. A more sensical way to do it, would be to [merge the...