Hyeoksu Lee
Hyeoksu Lee
@sbryngelson With the current golden files, the CI tests failed like right now. I think it is due to my changes, although I am not sure which parts are responsible...
@henryleberre I don't think there is an important update on output. Most changes are about input parameter and simulation process, not output file/data. I will check the code again and...
@sbryngelson I tried to remove the second length and velocity scales (bubble scales). On this PR, I was able to remove the second velocity scale, but I needed at least...
> You can resolve the merge conflicts with the formatting discussion here: #296 I didn't know that the conflicts are related to the formatting so I resolved conflicts in a...
I removed scaling parameters that I introduced previously, so the MFC has single normalization throughout the code. For now, tests on Phoenix have not been done, but all the others...
@sbryngelson Is there any procedure to test PR on GPUs with nvhpc/nvfortran other than just creating/updating PR? I haven't done simulations on GPUs or Phoenix, so I have no clue...
@sbryngelson I see. I can check it on Bridges2. Thanks!
@sbryngelson I have updated the documentation, code comments, and doxygen docstrings. Please let me know if you want more details or if anything is written in wrong format.
> @lee-hyeoksu I updated your first PR comment at the top, can you go through the relevant steps? Sure! Sorry for the delay.
@sbryngelson I have a question about a checklist item regarding `--nsys` since I have almost zero knowledge on Nsight Systems profile. I got informed a little bit from the MFC...