Hsiao-Wei Wang

Results 66 comments of Hsiao-Wei Wang

> A full validate_block has to be done at the chain level, because you need Chain to validate the uncles. @pipermerriam off-topic question: for beacon chain, do we have to...

@pipermerriam whoops sorry, my question was do I *have* to extract the block validation from `BeaconStateMachine.import_block` and `BeaconStateMachine.process_block`, and make `BeaconChain` trigger the block validation. Your second response answered my...

Nice catch! 😮 Hmm, although it's a typo, we will have a backward-compatible issue if we just rename the file. Probably need to rename + add an alias `primatives` for...

Agreed! We did consider using Cython to improve performance; especially that Serenity BLS signature aggregation would be one of the highest overhead.

@paulhauner Do you have the benchmark of SSZ v.s. RLP?

@djrtwo Should we add a task item of creating an EIP to handle `WithdrawalReceipt`?

Hi @torfbolt, At this moment, I'd say you might be able to get more feedback on [ethereum-magicians](https://ethereum-magicians.org) forum.

Took a look Viper and Nagini today. Some quick notes: - The verification system is great! - [Nagini requires input programs to comply to the static, nominal type system defined...

I think the spec is correct for flexible configuration as @protolambda mentioned, and py-ecc should be changed to follow the spec definition. Opened an issue https://github.com/ethereum/py-ssz/issues/116

> I put the tests in test_finality.py for now, but maybe I should make a new file? Yep! If it doesn't output any test vectors for client teams, it should...