hwangjeff

Results 9 comments of hwangjeff

looks good overall, and i agree with @carolineechen's recommendations. another nit is that the "torchaudio.transforms" just before the bulleted list of sections in the main body seems redundant

Hi @xvdp, thanks for flagging, and sorry for the late reply. For functions that convolve inputs, I think it would be a good idea to allow users to choose whether...

Hi @greaber — are you still seeing this? I tried this just now on OS X and it worked fine.

Note that #2740 addresses this by having `info` load and scan the file object to compute the frame count. It affects only mp3 files and those of formats not handled...

@gwenzek thanks for the feature request. This sounds good. Could you elaborate on how such an operator would differ from our existing convolution operators, e.g. [fftconvolve](https://pytorch.org/audio/main/generated/torchaudio.functional.fftconvolve.html#torchaudio.functional.fftconvolve) and [convolve](https://pytorch.org/audio/main/generated/torchaudio.functional.convolve.html#torchaudio.functional.convolve)? Re: RIR...

Hi @pfeatherstone, thank you for opening the issue. Could you share more details on your use case for us to figure out to how to address this?

Hi @pablf, sorry for the late reply. That sounds great. Which models would you like to work on?

@pablf sounds good — looking forward to it

Hi @vadimkantorov — thanks for flagging. Somewhat independently of this particular issue, we are indeed considering consolidating media I/O in a separate package. We'll post updates on the outcomes of...