Hernán Vanzetto

We should allow both, preferring the reactor first, with the option to override it with `--keypath` in the CLI. If both are empty, it should fail with a message. We...

Thanks for the feedback @hdevalence! I think what you want is something like the deprecated [priority mempool](https://github.com/cometbft/cometbft/blob/hvanz/mempool-qos-technical-design/docs/references/architecture/adr-113-mempool-lanes.md#cometbft-priority-mempool), where each tx has a priority? One of the main requirements for this...

> while this proposal would allow an app to define an IBC lane to prioritize IBC packets, this would do absolutely nothing about the IBC spam currently ongoing on deployed...

I just noticed this comment explaining the difference between error codes and errors in methods. I think that for app developers it's quite difficult to find, so better to put...

Thanks @ValarDragon for reporting this problem! I agree that rechecking should not block consensus, though it will still need to block the mempool for checking new incoming transactions. This is...

Also, #2268 is about a corner case in the rechecking logic, not related to current issue.

I'm also in favor of deprecating this metric. I don't think it's useful for a node operator but we would need to check. There was already a warning about the...

The problem is still open. No need to have a new issue; the problem is well stated here.

Some scattered documents related to the mempool: - Overview: https://github.com/cometbft/knowledge-base/blob/main/protocols/mempool-overview.md - There's a PR that updates and extends this document: https://github.com/cometbft/knowledge-base/pull/9/files - Diagram of v0 implementation: https://github.com/cometbft/knowledge-base/blob/main/protocols/mempool/v0/mempool-v0.md - RFC-103: https://github.com/cometbft/cometbft/blob/main/docs/rfc/rfc-103-incoming-txs-when-catching-up.md...

Some info on the field `ids: mempoolIDs` in the mempool reactor: https://github.com/cometbft/cometbft/pull/1043#discussion_r1251606701