Huynh Duc Duy
Huynh Duc Duy
same here :'(
I still have the same issue, @arjuntare did you managed to fix the problem yet?
> While that's technically true, what would be the point of putting a label on a button, when you can just put the label contents inside the button? The simplest...
Oh, if that is the case, then we have more things to do in this rule as well (as stated in https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label#accessibility_concerns) - disallow `button` and `input` with `type=button` -...
Alright, should I close this PR and open an issue for further discussion, then work on it via a future PR, or can I just keep this PR?
AFAIK this is very hard to implement. One possible path is using a naming convention and configuring the plugin to ignore/include specific components with regular expressions.
Additionally, we should validate it in the dependency array of built-in hook as well. For example, this should be considered warnings: ```ts function bar() { return {} // can be...
> Hi @huynhducduy , when can we expect to get it merged ? 🙏 @harshVardhan4743 Sorry but I don't know when @cvazac has the time to review it. At the...
> Thanks for working on this @huynhducduy! > > Today, we have `nativeAllowList`. [Soon](https://github.com/cvazac/eslint-plugin-react-perf/pull/73) we will have `allowList`. For consistency, maybe `ignoreComponents` should be `componentAllowList` and `ignoreImports` should be `importAllowList`...
Short answer: Yes Long answer: Yes, but not so easy. It would be hard to determine where the plugin should push the fix, the variable name,...