Huy Giang comments

Results 7 comments of


                                            Huy Giang

Prompt - check if vcs folder exist (.git, .svn, .hg) before getting vcs repo status

Ah, I missed that, thanks for pointing it out.

PID file not removed

`rm -f $pid_file` if the service stopped successfully, however, imo removing the pid file when it start cover more cases and make sure it have a clean start.

Validate errors on field arrays

cc @davidhenley

More pronounced visual difference between == and ===

+1 would love to have this, the only thing i want from Fira Code.

any possible way to disable 'data-react-helmet="true"' from server side rendering?

Anyways I can do this in the client? I have a React client side rendered page and trying to use meta tags for Twitter Card.

Chrome reloads infinitely when `serviceWorker.options.scope` is set

> This is my workaround which maybe useful for some cases. > > For me, I got infinite reload when init mswjs outside of service worker scope. > > let's...

[Bug]: (v7) Static Prerender Error: Cannot convert argument to a ByteString due to invalid character value

Worth noting that this behavior originates from Nodejs and is correct per spec - HTTP header cannot contains non-ascii characters: https://github.com/nodejs/undici/blob/b6d53fe93976b0d7a55438101b3f8c142d37afca/lib/web/fetch/webidl.js#L506 While pending for linked PR to be merged, another...