Thomas Veilleux issues

Repositories
Issues
Comments

Results 1 issues of


                                            Thomas Veilleux

Issues with using concretes instead of using an interface. In this case the repository should be responsible for creating the concrete and not the service.

https://github.com/elchris/kata_tdd_php_symfony/blob/929d832285e74180906bc60555120f9221a6dbfa/src/AppBundle/Service/RideService.php#L53 Eloquent doesn't pass properties in the constructor but your service requires it. ``` $flight = new Flight; $flight->name = $request->name; $flight->save(); ```