cskh
cskh
Actually the filename between ``checkbox-example.html`` and ``select-example.html`` should be exchanged.
Hi @shyamseshadri you may want to fix this to resolve the confusion when reading the book. Great examples!
@imranismail , could you in the PR update the doc (https://github.com/argoproj/argo-rollouts/blob/master/docs/features/traffic-management/istio.md#how-it-works) to mention that either, http, tls, or tcp is supported?
@jessesuen , I have a question about adding the `selector` filter for listing the 4 resources (rs, pod, experiment, and ar) in https://github.com/argoproj/argo-rollouts/blob/061efd4a527dafe74d42387ad2874ca24448b5c3/pkg/kubectl-argo-rollouts/viewcontroller/viewcontroller.go#L177-L192 I think using the `ro.spec.selector` only works...
@jessesuen , thanks for the suggestions. Let me try implementing this and get back to you.
@jessesuen , after some investigation, I realized that experiment and analysisrun have already have the `rollout-pod-template-hash` label. The only objects that misses the label is the analysisrun created by an...
@jessesuen , thanks for your comments. Please see my replies below > > 1. Pods which AnalysisRuns create (i.e. from the Job) are not labeled. And so we are forced...
@jessesuen , after some thought, I think it makes sense to introduce the rollout labels to the experiments and analysisrun created from rollout as the podTemplatehas is established. Please take...
> What will be the label value? Rollout UUID? The hash? If so, I agree that the label key could be more specific with something like rolloutUUID for example The...