Daniel
Cool, I've seen pagination done both ways. But yeah the one that specifies the start might be better.
sample response for ``` localhost:9980/wallet/addresses?start=1&limit=5 ``` ``` { "addresses": [ "2f03d9fcf3de30b905ae5cb992aed0f2a82dac9bc3ddbce630c8fe3b64fa633e6782fde4549e", "371bd3af1f153d246403c442ee91c6b042f3d7d1e42b35b61b2f8a2e6f2ff7e9691a51612e68", "40315eec5bbb186c3ec02fd385db8bd7125dc42d8709d8cf4cec7f85535ecb5afca1812d7cb7", "4267a2f33659f98770b4d90db7a0ac0af4bfb241c27bfc5721b9f3a347129e32cf58118354f9", "75ca2454b01b78b1b1aadd69c78f619aac03faf6d045fe012c25b28dfdf1c56f46c91b1cc77e" ], "pagination": { "start": 1, "limit": 5, "total_pages": 2 } } ```
Also, I'm not understanding the tests. I think the failure are unrelated to my changes?
Thanks for the review, I will address these comments after the holidays!
Hey, sorry forgot about this haha. Yeah I’ll have some time this weekend to get this out. On Thu, Feb 22, 2018 at 3:01 PM Thomas Bennett wrote: > @hudaniel...
updated @tbenz9 @DavidVorick
Should this boolean also be used for multi-sending?
I worked around this problem by replacing whitespaces with underscores
Yeah it's kind of ugly but I'm glad it helped!
So the current version of `GPUImage` is going to be not compatible with iOS 8.4? Will compiling the app with version `0.1.6` going to cause problems with this issue?