Hsuan-Yi Chu

icon indicating a website link www.linkedin.com/pub/sean-hsuan-yi-chu/59/9b1/304/ icon indicating an email [email protected]

icon company Databricks icon location San Francisco Bay Area icon location Search & Personalization

Results 6 comments of Hsuan-Yi Chu

DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SUBSTR

Except for the comments, LGTM. Do you run the unit test ?

DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SUBSTR

And can you share the details regarding the performance improvement? For example, how the setting and data look like? Observed % of improvements?

DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SUBSTR

@jcmcote Sorry for the delay. Let me run some tests and commit it if it passes the tests. Your contribution is highly appreciated.

DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SUBSTR

Yes, it passed the tests. I will push it shortly.

DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SUBSTR

Just pushed to master; Thanks for the contributions.

DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SUBSTR

Hi @jcmcote, I see. But can you do us a favor. Regex_replace()'s behavior changes after your patch https://issues.apache.org/jira/browse/DRILL-4645 Can you help fix this? And would you mind merging the missing...