Harrison Shoff

Results 44 comments of Harrison Shoff

Looks like a bug. `paddedMonthOf()` returns a "square" of days in the month. For example: The gray Sept `26-30` & Nov `1-6`.

Hi @PandaWhisperer, thanks for opening this Issue. Promises are a great place to have conventions in place for clarity. I'm going to leave this open for a bit to give...

Hi @gionkunz thanks for checking out the guide! We agree and we tried to add whys in the places it made sense. You can see the community opens up issues...

Hi @GochoMugo, to help us prioritize, which rules specifically could benefit from more explanation?

Let's just add an extra bullet to [Conditional Operators & Equality](https://github.com/airbnb/javascript#comparison-operators--equality) under `Use shortcuts.` that says `For readability, don't nest ternary operators.` (i realize there are fancier ways to write...

This falls in line with https://github.com/airbnb/javascript/issues/263 Definitely need to give this some more thought, but here are my initial thoughts. - I'm hesitant about rebranding/renaming because personally I don't agree...

Once @goatslacker's comments are addressed, this LGTM.

Hi @ianstormtaylor, thanks for reporting. I was able to reproduce the incorrect inferred type here: https://codesandbox.io/s/competent-sun-0n5r4?file=/src/App.tsx one workaround: another: ```ts const domain = [1, 2, 5, 10]; const range =...

It should not be required as it does nothing. This is a bug, `` is broken in current state. [``](https://github.com/airbnb/visx/blob/master/packages/visx-shape/src/shapes/Pie.tsx#L61-L66) still works because it doesn't use `` component, it uses...

Looks like our typescript doc generator doesn't follow the extended types which are defined here: https://github.com/airbnb/visx/blob/master/packages/visx-shape/src/shapes/Bar.tsx#L16 The additional props are the standard SVGRectElement attributes. Anything you can pass to ``...