Harshal Sheth

docs: make code highlighting look better

1

I picked these syntax themes because they looked good, but am not particularly attached to them - we can definitely change it around. Specifically, the vscode light theme's background color...

chore(ingest): drop python 3.6 support

2

## Checklist - [ ] The PR conforms to DataHub's [Contributing Guideline](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md) (particularly [Commit Message Format](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format)) - [ ] Links to related issues (if applicable) - [ ] Tests for...

Add `get_table_comment` method to inspection stub

1

See https://docs.sqlalchemy.org/en/14/core/reflection.html#sqlalchemy.engine.reflection.Inspector.get_table_comment

Add support for table/column comments in reflection

1

This implements the sqlalchemy reflection interface more completely: https://docs.sqlalchemy.org/en/14/core/reflection.html.

refactor(ingest): move common host_port validation

2

## Checklist - [ ] The PR conforms to DataHub's [Contributing Guideline](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md) (particularly [Commit Message Format](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format)) - [ ] Links to related issues (if applicable) - [ ] Tests for...

fix(ingest): hide deprecated path_spec option from config

2

## Checklist - [ ] The PR conforms to DataHub's [Contributing Guideline](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md) (particularly [Commit Message Format](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format)) - [ ] Links to related issues (if applicable) - [ ] Tests for...

fix(ingest): hide main github readme from docs site

2

Will fix search and some SEO issues. ## Checklist - [x] The PR conforms to DataHub's [Contributing Guideline](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md) (particularly [Commit Message Format](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format)) - [ ] Links to related issues (if...

docs: add sync status feature guide

2

Waiting on https://github.com/datahub-project/static-assets/pull/6 for screenshots. ## Checklist - [ ] The PR conforms to DataHub's [Contributing Guideline](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md) (particularly [Commit Message Format](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format)) - [ ] Links to related issues (if applicable)...

chore(ingest): bump and pin mypy

2

Used this codemod https://github.com/hauntsaninja/no_implicit_optional to upgrade our codebase's usage of implicit optionals. ## Checklist - [ ] The PR conforms to DataHub's [Contributing Guideline](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md) (particularly [Commit Message Format](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format)) - [...

fix(ingest): only require github_info for lookml and not looker

2

## Checklist - [ ] The PR conforms to DataHub's [Contributing Guideline](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md) (particularly [Commit Message Format](https://github.com/datahub-project/datahub/blob/master/docs/CONTRIBUTING.md#commit-message-format)) - [ ] Links to related issues (if applicable) - [ ] Tests for...