Gabor Garami

Results 109 comments of Gabor Garami

@nikic I'd like to see this project to not die. FastRoute is simple, easy to use and efficient routing solution if you don't want complex functionality. It works great with...

FastRoute runs perfectly on PHP 7.2 which I use for my current project, so it could be safely bumped. 😄

@lcobucci I'd prefer to see support 5.6 even if it's EOL since there is a lot of hostings that only supports this by default but make 7.2 as a recommended...

@lcobucci No need for separate thread, I absolute love the direction you facing to.

@GrahamCampbell As I currently see, nothing prevents Laravel to co-maintain FastRoute. Maybe together with Apidemia by @arhimede and @lcobucci?

This is why I recommended co-maintaining. It could help to reduce the maintenance work if two team can work on it.

My example is bit more weird: ``` $ORIGIN domain.com. test A 1.2.3.4 ``` results the record will be `test.domaincom`. Which is pretty not what I need.

@ancaemanuel if you don't want to accept a pull request, you should close it on your own. GitHub Issues Tutorial: https://www.youtube.com/watch?v=TJlYiMp8FuY Use the "Close issue" button below the comment box...

@Zenexer I missed the title, I thought he is a team member. Anyway, this is not a right way to handle issues.

I picked testing from @neclimdul 's pull request, however I try run composer only if it is really required, to be more specific: when composer.json is present. Also I removed...