Shatabarto "Rik" Bhattacharya
Shatabarto "Rik" Bhattacharya
@Amxx Hi! I have made changes accordingly (tests and changelog). Although some tests are failing. Is that worrying? Do let me know if I have to make more changes. Thank...
@Amxx oops, my bad, looks like all the tests have passed and I might have looked at the old test results. Please let me know your review and sorry for...
Hello @frangio. Will it be okay if I do a PR on this? It seems like something I can implement. Do let me know if there's more to it. Thanks!
Hello @frangio, you might remember me from #3598. Interested in implementing this, but I believe that you might have more things in mind.
I also had one question, should delay be immutable? I was thinking of more along the lines of having an overloaded function for _transferOwnership where the second parameter would be...
@frangio so are you against the idea of a library for delays? Or the library is over engineered you mean.
@nventuro, very interesting. I really liked the idea of minimum and maximum delay since oopsies can happen there. What I suggest is this. We can do an immutable min and...
Fair enough, btw should ownable be used or do you have from scratch implementation in mind? On Wed, 24 Aug, 2022, 2:48 am Francisco, ***@***.***> wrote: > The goal of...
Hi @MonkeyDo, the PR is ready for review, very very sorry for leaving you hanging, I was down with covid apparently, but I have recovered! I couldn't even attend the...
Also @MonkeyDo, I do need your help in one thing. For some reason, after merging the master, I have errors in frontend tests (and those errors don't appear to be...