Hugo Renard
Hugo Renard
@madisvain this translation looks good for at least two French speakers. Let me know if you need anything else. And thanks for your work!
Yes of course.
Hi @Nerzal ! Sorry for the delay. I also added GetComponentByID to facilitate the test :smile:.
Confirmation for every command is probably not the best the solution :sweat_smile:. I understand, "dry run" is not the best wording. I personally think downloading dependencies isn't an issue. Only...
I find the RFC not clear about this. You're right those schemas are the sames everywhere, then so is User and Group. And it's likely clients don't call them at...
Just an idea. Wouldn't be better to use generic regex like `application\/(\w+\+)?json` to cover potential future cases ?
Hi @kesselb, As I understand it, the ContactsManager (lib/private) is not responsible for filtering the results. Then, I don't see how the code would filter by groups as it only...
I want to add a test, but I'm no php developer. ```php $this->groupManager->expects($this->once()) ->method('isInGroup') ->will($this->returnValue(false)); $this->groupManager->expects($this->once()) ->method('isInGroup') ->with('auser', 'agroup') ->will($this->returnValue(true)); ``` Does this work ?
Hey, sorry to make noise. But it's a privacy issue, I think we should try to merge this soon.
Thanks for the feedback ! I added `testGetMatchingRecipientOnlyGroupUsers` for this use case, but I've not tried it.