homebeaver

Results 12 comments of homebeaver

@garydgregory done. I've also refreshed pulls #60 and #61

> Is it really necessary to have a separate class for each country? Also DE has a test class but no main class @sebbASF Yes. Each of the 28 countries...

Hi @garydgregory where does the test data come from? Different - I documented it in [wiki/VATIN](https://github.com/homebeaver/ungueltig/wiki/VATIN) - in German! You'll find examples in the Details-link: ![grafik](https://github.com/user-attachments/assets/3ae433e6-c391-4f6e-8bf5-303fbaf78a11)

> A nice to have item would be an update to the `package-info.java` file for the package Hi @garydgregory updated the `package-info.java` in `org.apache.commons.validator.routines ` Regards - next week I'm...

> ... VAT ID, NL004350351B91, is not accepted while it is in fact valid (confirmed with the online VIES check). I suspect this may have to do with a change...

> I looked around a bit but didn't find anything ... @raboof - I found this [BMF_UID_Konstruktionsregeln-Nov-2020.pdf bmf.gv.at](https://www.bmf.gv.at/dam/bmfgvat/finanzonline/fuer-softwarehersteller/sonstige-erklaerungen/Zusammenfassende-Meldung/BMF_UID_Konstruktionsregeln_Stand_November-2020.pdf)

> ... it does not check that the ID is actually in use. So I wonder what the use case is? @sebbASF Compare VATID to IBAN: validating an IBAN does...

> These look like bugs No. Imprecise comments + inconsistent code. Both resolved. Tkx

I've removed logging. There is one class with logging left : `TidDECheckDigit`. The reason is the specification - the link to it is in the class header. The spec is...

Hi @sebbASF , @sebbASF when merging apache/master to my repo branch I got an error in `pom.xml` ``` - cvc-elt.1.a: Cannot find the declaration of element 'project'. - Downloading external...