Andy Hochhaus
Andy Hochhaus
The author of `rules_closure` also added some comments on this at https://github.com/bazelbuild/rules_closure/issues/172.
It isn't very aesthetically pleasing but we could combine the bazel and closure logos.  On second thought, getting one of Google's graphic designers seems like a very good idea....
I did not explore this in depth but after a quick glance at the code I think this might be caused because MISSING_REQUIRE_CALL_WARNING is part of the [lintChecks diagnostic group](https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/DiagnosticGroups.java#L505)....
Good point, I clearly should have updated JsCheckerPassConfig.java as well. However doing so does not resolve the MISSING_REQUIRE_CALL_WARNING issue. It also catches a few new sets of warnings that need...
Great question. Yes, it also occurs with linter.jar. For example: ``` ahochhaus@ahochhaus-pc:~/rules_closure$ java -jar ~/closure-compiler-20160517/build/linter.jar bazel-rules_closure/external/closure_library/closure/goog/datasource/expr.js bazel-rules_closure/external/closure_library/closure/goog/datasource/expr.js:276: WARNING - missing require: 'goog.ds.DataManager' goog.ds.DataManager.getInstance(); ^ bazel-rules_closure/external/closure_library/closure/goog/datasource/expr.js:321: WARNING - Prototype property parts_...
I also confirmed that moving MISSING_REQUIRE_CALL_WARNING from lintChecks to the missingRequire diagnostic group makes the warning go away (since it will be correctly suppressed by the function level suppress). ```...
I think this is caused by https://github.com/google/closure-compiler/issues/1725. Hopefully it will be resolved by the next compiler release.
Closure Linter is been (or is nearly?) deprecated in favor of clang-format and JSChecker / linter.jar. https://github.com/bazelbuild/rules_closure/issues/41
Maybe, but I couldn't find the contrib externs. How would I reference [contrib/externs/chrome_extensions.js](https://github.com/google/closure-compiler/blob/master/contrib/externs/chrome_extensions.js)?
@pcj Sorry but I have not done any work on this yet.