Vinh Hoang comments

Results 224 comments of


                                            Vinh Hoang

I see that the PR is not ready yet, the checklist is not completed and recordings as well.

Please merge latest main to solve TS failed

Sorry for delay @Krishna2323, I will continue to review today

Just a few feedbacks, otherwise looks great.

@Krishna2323 let me know when the PR is ready to review again. Thanks

@Krishna2323 Could you help to fix the typescript and conflict? I will do review checklist right after that. Thanks

Could you check out to latest main and run `npm run typecheck`? It's weird that there is no TS error in latest main.

@Krishna2323 could you help to re-test again too? Thanks

@Krishna2323 could you give ETA when it will be ready for the next review? Thanks

Bug 1: Unable to select another currency https://github.com/Expensify/App/assets/9639873/46ffa8b6-6eee-44b2-9b54-8087c4527ae0