Steve Hoang

Hi. I'm wondering about the pattern you are using with State. Anytime state is changed from ViewModel Fragment/Activity should be triggered observed function. It gonna update whole view, state, recyclerview,......

The documentation is too bad, I can not subscribe a specific topic. Can you provide ?

* Auto release when LegacyYouTubePlayerView is detached from window

6

As discussed in https://github.com/PierfrancescoSoffritti/android-youtube-player/issues/1058 This PR will make the release function is called automatically. So developer who use this lib can put the view in Fragment, View... without care about...

Leaking issue in LegacyYouTubePlayerView

4

# Bug Report Leaking issue in LegacyYouTubePlayerView ### Description of the Bug In init block of LegacyYouTubePlayerView. You're adding the listener to NetworkBroadcastReceiver ``` networkObserver.listeners.add(object : NetworkObserver.Listener { override fun...

Fix leaking issue when add lifecycle observer

4

Since the context is using ActivityLifeCycle. So trying to add lifeCycleObserver without remove when the view is being detached will causing leak memory issue. The lifeCycleObserver is already remove itself...