Harun Mustafa

Results 13 comments of Harun Mustafa

I set up the unit tests for chaining, now I just need to add a few more to test corner cases.

> Is this ready for review? Yes

We do indeed need to write about this in the documentation. For now, refer to #460 for an explanation of the output.

I was looking into this and I noticed that the only SIMD commands used in KMC (`_mm_stream_si64` and `_mm_stream_si128`) have no equivalents in ARM (at least, none that I could...

Thanks for your interest! You can use [`ExternalProject_Add`](https://cmake.org/cmake/help/latest/module/ExternalProject.html) to add MetaGraph to your project, then link to `libmetagraph-core.a`

If you run into any issues with my suggestion, could you please post your `CMakeLists.txt` here?

My environment is gcc-12 with Ubuntu 20.04 and this doesn't seem to be an issue, `target_compile_options(PTHASH INTERFACE -pthread)` works fine

> @hmusta I tried using Metagraph as an external project, and besides problems with includes (that are at least resolved by this commit), I also get a bunch of linking...

> This is true, but currently Metagraph doesn't even install it in the install dir: > > ```shell > $ ls install/lib/ > cmake libjsoncpp.a libmetagraph-core.a libz.a pkgconfig > ```...