Hong Liang Teoh

Results 21 comments of Hong Liang Teoh

The code changes look good. Recognise that we specify a KryoSerializer instead of making the SequenceNumber a POJO to maintain backwards compatibility. Given that we are changing the state serializer,...

We have now moved the consumer here https://github.com/apache/flink-connector-aws as part of the connector externalisation effort!

Hi @vahmed-hamdy, my preference would be for us to refactor the code in `DynamoDbTypeInformedElementConverter` to use a cleaner structure rather than a long list of `if-else`. Is this something we...

We seem to be having quite a few `.` in the class folders. Can we change them to `/` instead? e.g. `flink-connector-aws/flink-connector-sqs/src/test/java/org.apache.flink/connector.sqs/sink/SqsExceptionClassifiersTest.java

@19priyadhingra The tests seems to be failing. Can we please take a look? Also - it would be good if we squash the commits!

> Do you have any suggestion on how can I fix my test case without reverting that PR? Hi @19priyadhingra, we can either debug the local stack issue, or consider...

Hmm, I can't seem to replicate the build error locally. Could we try re-running the checks? Done this: ``` mvn clean package -Dflink.version=1.17-SNAPSHOT ``` and ``` mvn clean package -Dflink.version=1.16-SNAPSHOT...

Closing as this, as we have decided we want to have a separate `common.yml` to add support for pulling credentials for `AWS e2e tests`

@Sunninsky Hey! We are currently working on implementing EFO support for the new source connector. Estimate maybe end of the quarter?