Marijn Schouten

The README currently specifies to use `extern crate wee_alloc;`, but this is only needed for Rust 2015 and not for Rust 2018. This is distracting for new Rust users who...

Document how to publish to Github Pages

1

When deploying on Github Pages it is necessary to pass `--public-url ${{ github.event.repository.name }}` when building with trunk. Might be good to document this. A full example is here: https://github.com/hkBst/tic-tac-toe-seed/blob/main/.github/workflows/deploy.yml

Run tests with miri

1

Currently I do not see an option to run "cargo miri test" to run the tests through miri. Perhaps I missed it, but otherwise it would be a useful addition.

rsx macro fails to parse with confusing error message: missing trailing comma

2

**Problem** rsx macro fails to parse with confusing error message **Steps To Reproduce** This code ``` use dioxus::prelude::*; fn main() { launch(app); } fn app() -> Element { rsx!( div...

base_path needed for deploy, but breaks local serve

2

**Problem** I need to set [web.app]base_path in Dioxus.toml to get deployment on Github Pages working. But then locally the app refuses to work as it is replaced by an error...

Currently only RUSTC is used, but it may make sense to also support RUSTC_WRAPPER. Would you accept a patch that implements that?

Current rerun-if directives include just the build/build.rs file itself, but not its cousin build/rustc.rs. Shouldn't the entire build directory be used instead? That way cargo will rerun if any of...

Inline peek_ahead to fix 186 and remove iter::peek_ahead as it is now unused.

2

Fixes #186

iter::slice_skip remove possibility of underflow in debug_assert

1

`self.cursor.sub(skip)` must point inside the allocation of this object or this is UB, not to mention the possibility that if `skip` if very large self.cursor.sub(skip) may underflow and fail to...