Takuro Hishikawa comments

Results 117 comments of


                                            Takuro Hishikawa

Permission setting

Why don't you use `FILE_PERMISSIONS_MODE` instead of hardcoded `0666`?

Request for subdivisions (provinces or states) from ISO 3166-2

:+1:

Request for subdivisions (provinces or states) from ISO 3166-2

Sounds good.

Request for subdivisions (provinces or states) from ISO 3166-2

🍾

getAttribute error while the attribute name include '-'

Could you try `$element->{'data-lazyload'}` ?

Can't refresh doctrine entities, got discriminator map error

Off course I did

Can't refresh doctrine entities, got discriminator map error

* Community Store v.2.2.7 * Community Store Export Data v.0.2 * S3 Storage v.3.0.3 * C5j Stripe v.0.0.4

Can't refresh doctrine entities, got discriminator map error

Any updates?

[Performance Improvement] Cache more blocks for registered users

Yeah I agree.

[Performance Improvement] Cache more blocks for registered users

Generally speaking, I don't want to break backward compatibility. However, it's nonsense not to cache output that is just pulled attribute value of the page.