Himanshu Pathak

Results 11 comments of Himanshu Pathak

Hi @johnbillion. I have added the unit tests and updated the existing test files. Now, all the tests are passing. Let me know if the changes look good to you....

@nikunj8866 After investigation, I found that the notification is triggered in the multisite environments behaves differently, and an extra email is being triggered, which is failing the tests. https://github.com/WordPress/wordpress-develop/actions/runs/14440085345/job/40488175505?pr=8672 Can...

> @himanshupathak95 Password Changed email additional triggered for multisite. Thanks @nikunj8866 for following up and testing this out. However, ever after applying the latest commit, the tests are still failing....

Hi @jp-imagines, Thank you for the report! I've analyzed this issue and can confirm the problem. The root cause involves both global styles and individual block settings. As correctly mentioned,...

The failing tests seem unrelated to the changes made in the PR.

Here is a screencast of the keyboard navigation for all the sections - https://github.com/user-attachments/assets/2e8609ae-8ef5-413a-a49c-bfd40ed676bc

Thanks, @t-hamano, for the suggestions. I have updated all the places needed for keyboard navigation. After testing, I found that the JS code change is not necessary since the tabindex...

Hi all, thanks @t-hamano for the thoughtful approaches. I think adding `.first()` to the playwright locator seems like the most direct and least disruptive way to address this problem. My...

I think the simplest fix would be the first point of discussion, but I would like this to be properly discussed before proceeding with a fix.

> Personally, I feel it's more natural to position the popover on the right: @t-hamano I tried all the possible props for the `position` and `placement` props, and the only...