Bex Warner
Bex Warner
Good catch. Would likely require some smarter checking here: https://github.com/probot/dco/blob/bce3d1bb684f0aa03c733e70327142ddb811f4c4/index.js#L61 to make sure the commit is the most recent. If not it can just handle all commits.
I am very disheartened to see GitHub abandon running these apps, especially so suddenly and without any warning. I think that was a horribly unfair move @github. I don't have...
https://developercertificate.org/ works fine for me. PRs welcome to edit the text in the checks DCO creates. Developer Certificate of Origin
The 'verified' indicator on github ensures the commit was signed with a [GPG](https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/signing-commits) key. Signing your commit with a GPG key is not equivalent in most circles to agreeing to...
No worries. Most of the guidance from this repo has come from the Linux Foundation who are heavy DCO users (and usually confer with their lawyers on these things -...
there's 2 main tests in this repo and they have very different methodology. The [first](https://github.com/probot/dco/blob/master/test/index.test.js) uses github api mocks, so you'd mock the return of fetching the config files content...
PRs welcome to make it disable-able, but that was a highly requested feature. It is only available for those with write access, ie people who could overwrite the check anyways.
hey I just took a look and the pr looks good. I'll try to test it out tonight.. Not sure if there's any good way to write tests for it,...
Sorry for the delay in getting back on this, but yes don't disagree that this sucks. Would happily review and merge a PR to check for the commit diff and...
Basically, all the mocks that are being created are for node-github, and I think creating mocks for all of node-github, or some simpler programmatic way of doing so is probably...